Fix wrong path to Helm values file in the quickstart #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipecd-bot
added
do-not-merge/release-note-needed
size/XS
area/docs
area/site
release-note-none
and removed
do-not-merge/release-note-needed
labels
khanhtc1202
reviewed
May 15, 2022
| @@ -20,7 +20,7 @@ Note: It's not required to install the PipeCD control plane to the cluster where | |||
| ``` console | |||
| helm install pipecd oci://ghcr.io/pipe-cd/chart/pipecd --version {{< blocks/latest_version >}} \ | |||
| --namespace pipecd --create-namespace \ | |||
| --values https://raw.githubusercontent.com/pipe-cd/manifests/{{< blocks/latest_version >}}/quickstart/control-plane-values.yaml | |||
| --values https://raw.githubusercontent.com/pipe-cd/pipecd/{< blocks/latest_version >}}/quickstart/control-plane-values.yaml | |||
There was a problem hiding this comment.
Suggested change
| --values https://raw.githubusercontent.com/pipe-cd/pipecd/{< blocks/latest_version >}}/quickstart/control-plane-values.yaml | |
| --values https://raw.githubusercontent.com/pipe-cd/pipecd/{{< blocks/latest_version >}}/quickstart/control-plane-values.yaml |
|
Nice catch 👍 Could you update docs under |
|
OK, I do. BTW, I tried quickstart on kind of Apple Silicon's Mac. The following is Pod's status. I confirm problem to do I think it seems like this problem is occurred by invalid platform. How to resolve it. |
sivchari
force-pushed
the
fix-quickstart-installation
branch
from
5def083
to
c225435
Compare
@sivchari From this error message, this is caused by docker4mac trying to pull MySQL official image from docker-hub. Since docker-hub does not contain MySQL image for M1, you should use the following command to pull the MySQL image.
After this command, helm will use the local pulled image, so there is no need to worry about that later 😄 |
docker imagesshell scripthelm install pipecd oci://ghcr.io/pipe-cd/chart/pipecd --version v0.31.0 --namespace pipecd --create-namespace --values https://raw.githubusercontent.com/pipe-cd/pipecd/v0.31.0/quickstart/control-plane-values.yamlkubectl get pod -n pipecdkubectl get events -n pipecdI can't 😢 |
nghialv
changed the title
|
@sivchari Nice catch! Thank you. 💯 |
nghialv
approved these changes
May 16, 2022
|
@sivchari, thanks for reporting. Could you open an issue for the error and send all possible logs there. We will find out a way to handle it there. |
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I fixed quick start guide.
https://raw.githubusercontent.com/pipe-cd/manifests/{{< blocks/latest_version >}}/quickstart/control-plane-values.yamlis incorrect path. (404)Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: