Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the docs to add analysis type #3641

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix the docs to add analysis type #3641

merged 1 commit into from
May 19, 2022

Conversation

knanao
Copy link
Member

@knanao knanao commented May 19, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@knanao knanao marked this pull request as ready for review May 19, 2022 05:52
@khanhtc1202
Copy link
Member

Just don't remember which version we added the Datadog as AnalysisProvider 😂

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@knanao
Copy link
Member Author

knanao commented May 19, 2022

@khanhtc1202
Me neither, but as you can know from the article, it would be after v0.25.0.
that's why this is fine🙌
https://github.com/pipe-cd/pipecd/blob/master/docs/content/en/docs-v0.25.x/operator-manual/piped/adding-an-analysis-provider.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants