Fix app config reporter skip sync configuration on adding app #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed while validating Kapetanios configuration. Details |
Co-authored-by: knanao <[email protected]>
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, piped can only update the application configuration when the repository which contains that app has new commits after the application be registered to the pipecd database. In case of the app configuration had existed before the app be added, the new registered application configuration can not be synced. This PR updates the logic on appconfigreporter package to ensure the piped only skip syncing applications in case of application's last commit has been scanned, not in case of the application containing repository's last commit has been scanned as currently.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: