Fix not to return an error when the data point of metrics was empty #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knanao
changed the title
nghialv
reviewed
May 24, 2022
nghialv
reviewed
May 25, 2022
nghialv
reviewed
May 25, 2022
Co-authored-by: nghialv <[email protected]>
Co-authored-by: nghialv <[email protected]>
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, every analysis stage returns an error if the data point of metrics was empty.
But there are some cases in which this one is empty intentionally.
(ex. the cases in which the user only handles an error log as metrics and so on.)
Hence, I fixed not to return an error when that data was empty.
Which issue(s) this PR fixes:
#3661
Fixes #
Does this PR introduce a user-facing change?: