Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web lint command to makefile #3678

Merged
merged 3 commits into from
May 27, 2022
Merged

Add web lint command to makefile #3678

merged 3 commits into from
May 27, 2022

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented May 26, 2022 •
edited
Loading

What this PR does / why we need it:

Add lint command and fix all current lint issues in web source

# make lint/web
yarn --cwd web lint
yarn run v1.22.10
$ eslint --ext .ts,.tsx ./src
Done in 14.72s.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) May 26, 2022 09:45
knanao
knanao approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

nghialv
nghialv approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@khanhtc1202 khanhtc1202 merged commit 3bbcdab into master May 27, 2022
@khanhtc1202 khanhtc1202 deleted the add-lint-cmd branch May 27, 2022 02:08
This was referenced May 27, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knanao knanao knanao approved these changes

@nghialv nghialv nghialv approved these changes

@Szarny Szarny Awaiting requested review from Szarny

Assignees
No one assigned
Labels
area/build area/web release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khanhtc1202 @nghialv @knanao @pipecd-bot