Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version warning banner to web console #3679

Merged
merged 3 commits into from
May 27, 2022
Merged

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

The UI looks like this

Kapture.2022-05-26.at.16.36.25.mp4

The banner will disable once users click on the close button and only display again when the new version had released.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Show a warning banner that aware users when a new PipeCD version had released

Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@khanhtc1202 khanhtc1202 merged commit 9768968 into master May 27, 2022
@khanhtc1202 khanhtc1202 deleted the add-warning-banner branch May 27, 2022 04:21
This was referenced May 27, 2022
@github-actions github-actions bot mentioned this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants