Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the LoadApplication function in the config package #3730

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

knanao
Copy link
Member

@knanao knanao commented Jun 6, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

pkg/config/application.go Outdated Show resolved Hide resolved
nghialv
nghialv previously approved these changes Jun 7, 2022
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go!

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 🎸

Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@knanao knanao enabled auto-merge (squash) June 7, 2022 02:41
@knanao knanao merged commit bdf86d5 into master Jun 7, 2022
@knanao knanao deleted the load-app-config branch June 7, 2022 03:27
@github-actions github-actions bot mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants