Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform provider to application, deployment and piped model #3756

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Jun 20, 2022

The CI job does not pass.

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Add validation for this field.

// TODO: Add validation for this field.
PlatformProvider string `protobuf:"bytes,15,opt,name=platform_provider,json=platformProvider,proto3" json:"platform_provider,omitempty"`
// Additional description about application.
Description string `protobuf:"bytes,9,opt,name=description,proto3" json:"description,omitempty"`

This was created by todo plugin since "TODO:" was found in e4f4816 when #3756 was merged. cc: @khanhtc1202.

2. Add validation for this field.

// TODO: Add validation for this field.
string platform_provider = 15;
// Additional description about application.
string description = 9;

This was created by todo plugin since "TODO:" was found in e4f4816 when #3756 was merged. cc: @khanhtc1202.

@khanhtc1202
Copy link
Member Author

/todo skip

Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go!

@khanhtc1202 khanhtc1202 merged commit d202f31 into master Jun 20, 2022
@khanhtc1202 khanhtc1202 deleted the add-platform-provider-field branch June 20, 2022 08:43
@github-actions github-actions bot mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants