Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the type assertion for event watcher cache #3758

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Fix the type assertion for event watcher cache #3758

merged 2 commits into from
Jun 21, 2022

Conversation

knanao
Copy link
Member

@knanao knanao commented Jun 21, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@knanao knanao marked this pull request as ready for review June 21, 2022 04:03
nghialv
nghialv previously approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@knanao knanao enabled auto-merge (squash) June 21, 2022 04:05
@knanao
Copy link
Member Author

knanao commented Jun 21, 2022

@nghialv @khanhtc1202
Sorry, I fixed some points, so please review this again when you guys have time.

nghialv
nghialv approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

khanhtc1202
khanhtc1202 approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@knanao knanao merged commit 4fef8f3 into master Jun 21, 2022
@knanao knanao deleted the fixup branch June 21, 2022 05:44
@github-actions github-actions bot mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghialv nghialv nghialv approved these changes

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

Assignees
No one assigned
Labels
area/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knanao @nghialv @khanhtc1202