Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the cherry-pick script as a hack command #3808

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Conversation

knanao
Copy link
Member

@knanao knanao commented Jul 14, 2022

What this PR does / why we need it:
This is a command for core contributors in order to cherry-pick bug fixes to a release branch.

Prerequisites

  • The release branch exists. (ex. release-0.1)
  • The pull request to cherry-pick was already merged.
  • (optional) If you push commits and create a pull request, gh is needed to be installed and ran gh auth login.
    Please refer to gh-cli.

Usage

$ hack/cherry-pick.sh -qc $RELEASE_BRANCH $PULL_REQUEST_NUMBER...

Example

$ hack/cherry-pick.sh -qc release-0.35 3808

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Jul 14, 2022

gh was already installed and ran gh auth login. Please refer to gh-cli.

I know that gh is needed to create a new PR via CLI but I feel that this requirement could reduce our flexibility.
🤔

@knanao
Copy link
Member Author

knanao commented Jul 14, 2022

@nghialv
I feel your points too.
So how about making it an option to create a pull request, or we'll try it once anyway?

@nghialv
Copy link
Member

nghialv commented Jul 14, 2022

how about making it an option to create a pull request

Nice idea. Making it as an option is a better way. 👍

@knanao
Copy link
Member Author

knanao commented Jul 14, 2022

@nghialv
Thank you for your reviews.
I fixed some points, so please check it again.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@knanao knanao merged commit ac2a709 into master Jul 20, 2022
@knanao knanao deleted the cherry-pick-script branch July 20, 2022 05:37
@github-actions github-actions bot mentioned this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants