Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the incorrect conversion between integer types #4034

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

knanao
Copy link
Member

@knanao knanao commented Dec 1, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@knanao knanao enabled auto-merge (squash) December 1, 2022 02:00
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

@knanao knanao merged commit 93e33df into master Dec 1, 2022
@knanao knanao deleted the conversion branch December 1, 2022 03:04
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
knanao added a commit that referenced this pull request Dec 2, 2022
* Avoid the incorrect conversion between integer types

* Fix the error text
knanao added a commit that referenced this pull request Dec 2, 2022
* Update release note (#4032)

* Avoid the incorrect conversion between integer types (#4034)

* Avoid the incorrect conversion between integer types

* Fix the error text

* Fix comment in docs (#4035)

* Fix comment in docs

* Remove unneeded char

* Make chunkMaxCount configurable for Insight collector (#4036)

* Remove unneeded code (#4038)

* Refactor api loading for Insights data on web (#4039)

* Move api loading logic from insight-header to insight

* Disable api loading for deployment insights

* Release v0.40.1 (#4040)

* Release v0.40.1

* Update release note

Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: nghialv <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants