Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app live resource lister wrong attribute #4072

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Fix the appLiveResourceLister attribute, previously this bug could not be found because we keep both CloudProvider and PlatformProvider duplicated in the Application model.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

KAPETANIOS

Failed while validating Kapetanios configuration.

Details
Error: rpc error: code = NotFound desc = not found

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 13, 2022 09:18
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@khanhtc1202 khanhtc1202 merged commit dabcc05 into master Dec 13, 2022
@khanhtc1202 khanhtc1202 deleted the fix-app-live branch December 13, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants