Support setting kubectlVersion via piped config #4081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do think we have discussed supporting such a feature before, but I forgot what makes us happy. |
|
Well can say that at some places where users don't want config kubectl version on their application configuration and at the same time, they want to use kubectl at a newer version than the piped default version, this change could help, wdyt? |
|
Right, as you mentions, it's a hassle to specify per the application configuration file. |
knanao
approved these changes
Dec 16, 2022
|
Nice catch, tbh I got this from nghialv directly without checking the issue tracker 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The priority to determine kubectl version would be:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: