Update planpreview comment format #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanhtc1202
reviewed
Jan 4, 2023
| @@ -178,11 +178,13 @@ func makeCommentBody(event *githubEvent, r *PlanPreviewResult) string { | |||
| b.WriteString(fmt.Sprintf(hasChangeTitleFormat, event.HeadCommit, len(r.Applications))) | |||
|
|
|||
| changedApps, pipelineApps, quickSyncApps := groupApplicationResults(r.Applications) | |||
| if len(changedApps)+len(pipelineApps)+len(quickSyncApps) > 0 { | |||
| b.WriteString("\n## Plans\n\n") | |||
There was a problem hiding this comment.
Suggested change
| b.WriteString("\n## Plans\n\n") | |
| b.WriteString("\n## Plans Preview\n\n") |
how about this?
There was a problem hiding this comment.
umm, if u wanna do this, I feel Plan Preview or Plan Previews are more natural.
There was a problem hiding this comment.
Then I think I will go with Plan Preview but it's up to you 👍
There was a problem hiding this comment.
IMO, I feel Plans is enough because this action is planpreview, so let's keep this. 🙌
khanhtc1202
approved these changes
Jan 5, 2023
Merged
knanao
added a commit
that referenced
this pull request
Jan 6, 2023
* Update planpreview comment format * fixup
knanao
added a commit
that referenced
this pull request
Jan 6, 2023
* Fix to return an error when not finding the last commit (#4100) * Update planpreview comment format (#4101) * Update planpreview comment format * fixup * Update the planpreview format (#4103) * Remove deprecated envName field (#4105) * Release v0.41.2 (#4111) * Release v0.41.2 * Update the release note Co-authored-by: Khanh Tran <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before
①
②
After
①
②
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: