Add last use of api key on webui #4124

kevin-namba · 2023-01-12T04:33:52Z

What this PR does / why we need it:
Enabling us to know when api keys are created and used at last time.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

add created-time and last-used-time of api keys on web-ui

… them in verifier

knanao · 2023-01-16T01:19:48Z

@kevin55156
Great, it's better to be able to check what gRPC was called too by a API key next.

Anyway, Thank you for your nice work. 🚀

web/src/components/settings-page/api-key/index.tsx

pkg/app/server/apikeyverifier/verifier.go

fix

kevin-namba · 2023-01-19T04:41:16Z

@kevin55156 Great, it's better to be able to check what gRPC was called too by a API key next.

Thank you, I think so, too.
I will create the new issue about this feature.
#4136

pkg/app/server/apikeyverifier/verifier.go

pkg/datastore/apikey.go

…/pipecd into add-last-use-of-api-key-on-webui

lint

knanao · 2023-02-08T02:09:02Z

pkg/app/server/apikeyverifier/verifier.go

 }

-func NewVerifier(ctx context.Context, getter apiKeyGetter, logger *zap.Logger) *Verifier {
+const apiKeyLastUsedCacheHashKey = "HASHKEY:PIPED:API_KEYS" //nolint:gosec


[nits] I feel it's better to make it sharding per project.
Because it's supposed to be called per a project.

Server must decide hash key name before NewVerifier is called, but which project is not decided at that time.
Piped client is associated with one project, but defaultPipedStatHashKey does not include project id because of the same reason.

pkg/app/server/apikeyverifier/verifier.go

pkg/app/server/grpcapi/web_api.go

khanhtc1202 · 2023-02-09T10:58:38Z

cmd/pipecd/server.go

@@ -69,7 +69,8 @@ var (
 )

 const (
-	defaultPipedStatHashKey = "HASHKEY:PIPED:STATS"
+	defaultPipedStatHashKey    = "HASHKEY:PIPED:STATS"
+	apiKeyLastUsedCacheHashKey = "HASHKEY:PIPED:API_KEYS" //nolint:gosec


Just want to confirm, do we still need this nolint annotation?

Yes, CI golang-cli fails without this nolint

pkg/app/server/apikeyverifier/verifier.go

Co-authored-by: Khanh Tran <[email protected]>

pkg/app/server/apikeyverifier/verifier_test.go

khanhtc1202

Nice work 🙌

kevin-namba added 2 commits January 12, 2023 11:05

add last-used-at field to model

4dffe7c

add created time and last used time on webui and the method to update…

be1fda7

… them in verifier

kevin-namba requested review from nghialv, khanhtc1202 and knanao as code owners January 12, 2023 04:33

github-actions bot added area/go area/web labels Jan 12, 2023

kevin-namba added 2 commits January 12, 2023 13:45

ts lint

2def74d

modify verify test

ee25d8d

kevin-namba changed the title ~~[WIP] Add last use of api key on webui~~ Add last use of api key on webui Jan 12, 2023

Merge branch 'master' into add-last-use-of-api-key-on-webui

847efbe

khanhtc1202 reviewed Jan 16, 2023

View reviewed changes

web/src/components/settings-page/api-key/index.tsx Outdated Show resolved Hide resolved

khanhtc1202 reviewed Jan 16, 2023

View reviewed changes

pkg/app/server/apikeyverifier/verifier.go Outdated Show resolved Hide resolved

kevin-namba added 2 commits January 18, 2023 15:16

move lastusedat

6038e5c

delete consolelog

233eeda

fix

kevin-namba force-pushed the add-last-use-of-api-key-on-webui branch from 092df88 to 233eeda Compare January 18, 2023 09:21

kevin-namba mentioned this pull request Jan 19, 2023

Show histories when the API key was used and who use the key. #4136

Closed

khanhtc1202 reviewed Jan 19, 2023

View reviewed changes

pkg/app/server/apikeyverifier/verifier.go Outdated Show resolved Hide resolved

khanhtc1202 reviewed Jan 19, 2023

View reviewed changes

pkg/app/server/apikeyverifier/verifier.go Outdated Show resolved Hide resolved

change datastore to cache to save last used at time

161a7e1

github-actions bot added the area/build label Feb 1, 2023

kevin-namba and others added 3 commits February 1, 2023 18:38

change checkapi to member function

fed2233

change checkapi to member function

4e61f73

Merge branch 'master' into add-last-use-of-api-key-on-webui

0a0d42b

github-actions bot removed the area/build label Feb 1, 2023

khanhtc1202 reviewed Feb 1, 2023

View reviewed changes

pkg/datastore/apikey.go Outdated Show resolved Hide resolved

kevin-namba added 2 commits February 1, 2023 19:21

delete datastore setting

7aec986

Merge branch 'add-last-use-of-api-key-on-webui' of github.com:pipe-cd…

409aa3b

…/pipecd into add-last-use-of-api-key-on-webui

kevin-namba added 2 commits February 2, 2023 15:53

modify verify_test

5323943

lint

78392e4

lint

kevin-namba force-pushed the add-last-use-of-api-key-on-webui branch from 75568e6 to 78392e4 Compare February 6, 2023 09:41

knanao reviewed Feb 8, 2023

View reviewed changes

khanhtc1202 reviewed Feb 8, 2023

View reviewed changes

pkg/app/server/apikeyverifier/verifier.go Outdated Show resolved Hide resolved

khanhtc1202 reviewed Feb 8, 2023

View reviewed changes

pkg/app/server/grpcapi/web_api.go Outdated Show resolved Hide resolved

change variable of NewVerifier

b8b523b

kevin-namba force-pushed the add-last-use-of-api-key-on-webui branch from 806de36 to b8b523b Compare February 9, 2023 04:13

kevin-namba added 2 commits February 9, 2023 13:18

create now reciever

3f2b534

change variable of NewWebAPI

ba18ca9

kevin-namba force-pushed the add-last-use-of-api-key-on-webui branch from 6d59e7f to ba18ca9 Compare February 9, 2023 04:36

lint

a1cd817

khanhtc1202 reviewed Feb 9, 2023

View reviewed changes

pkg/app/server/apikeyverifier/verifier.go Outdated Show resolved Hide resolved

khanhtc1202 reviewed Feb 9, 2023

View reviewed changes

pkg/app/server/apikeyverifier/verifier.go Outdated Show resolved Hide resolved

modify now Func

c242dce

kevin-namba force-pushed the add-last-use-of-api-key-on-webui branch from ce4aa88 to c242dce Compare February 13, 2023 06:20

kevin-namba and others added 3 commits February 13, 2023 15:21

Update pkg/app/server/apikeyverifier/verifier.go

e32c4c7

Co-authored-by: Khanh Tran <[email protected]>

Merge branch 'master' into add-last-use-of-api-key-on-webui

09906ba

change interface

daa9151

khanhtc1202 reviewed Feb 16, 2023

View reviewed changes

pkg/app/server/apikeyverifier/verifier_test.go Show resolved Hide resolved

Update pkg/app/server/apikeyverifier/verifier_test.go

446a1e2

khanhtc1202 approved these changes Feb 16, 2023

View reviewed changes

Merge branch 'master' into add-last-use-of-api-key-on-webui

99df5d9

khanhtc1202 enabled auto-merge (squash) February 16, 2023 10:47

khanhtc1202 merged commit 4d2a89c into master Feb 16, 2023

khanhtc1202 deleted the add-last-use-of-api-key-on-webui branch February 16, 2023 10:50

kevin-namba mentioned this pull request Feb 17, 2023

Add last used time cron updater #4201

Merged

khanhtc1202 mentioned this pull request Feb 24, 2023

Update api key list UI #4221

Merged

github-actions bot mentioned this pull request Feb 27, 2023

Release v0.42.0 #4226

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add last use of api key on webui #4124

Add last use of api key on webui #4124

kevin-namba commented Jan 12, 2023

knanao commented Jan 16, 2023

kevin-namba commented Jan 19, 2023 •

edited

Loading

knanao Feb 8, 2023

kevin-namba Feb 9, 2023

khanhtc1202 Feb 9, 2023

kevin-namba Feb 13, 2023

khanhtc1202 left a comment

Add last use of api key on webui #4124

Add last use of api key on webui #4124

Conversation

kevin-namba commented Jan 12, 2023

knanao commented Jan 16, 2023

kevin-namba commented Jan 19, 2023 • edited Loading

knanao Feb 8, 2023

Choose a reason for hiding this comment

kevin-namba Feb 9, 2023

Choose a reason for hiding this comment

khanhtc1202 Feb 9, 2023

Choose a reason for hiding this comment

kevin-namba Feb 13, 2023

Choose a reason for hiding this comment

khanhtc1202 left a comment

Choose a reason for hiding this comment

kevin-namba commented Jan 19, 2023 •

edited

Loading