Change build tag every time when make run/pipecd #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-namba
requested review from
nghialv,
khanhtc1202 and
knanao
as code owners
khanhtc1202
reviewed
Jan 13, 2023
khanhtc1202
reviewed
Jan 13, 2023
khanhtc1202
approved these changes
Jan 19, 2023
knanao
pushed a commit
that referenced
this pull request
Feb 7, 2023
* add unix time to tail of build tag * modify assigning * change variable name * change type pf assign
knanao
added a commit
that referenced
this pull request
Feb 7, 2023
#4157 #4161 (#4163) * Templating commit message used by Event watcher (#4120) * Added ability to teplate eventWatcher.gitRepos.commitMessage * parse template in the eventWatcher handler side * Parse template in the eventWatcher handler side * Fix html/template to text/template * There was a useless process when retrieving rules, so I omitted it. * Delete html/template * Update pkg/app/piped/eventwatcher/eventwatcher.go Co-authored-by: Khanh Tran <[email protected]> * Update pkg/app/piped/eventwatcher/eventwatcher.go Co-authored-by: Khanh Tran <[email protected]> * Using template variables are only Value and EventName. * Update pkg/app/piped/eventwatcher/eventwatcher.go Co-authored-by: knanao <[email protected]> * Update pkg/app/piped/eventwatcher/eventwatcher.go Co-authored-by: knanao <[email protected]> * Fix syntax error * Update pkg/app/piped/eventwatcher/eventwatcher.go Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: knanao <[email protected]> * Add environment variable expire web session (#4127) * add field session-ttl to project * edit values * reflect ttl config to session * return values * add field in document * return config * change variable name * modify document and manifest * modify docs * change minites tp hours * regen * Change build tag every time when make run/pipecd (#4130) * add unix time to tail of build tag * modify assigning * change variable name * change type pf assign * Fix docs wrong params name (#4132) * Fix pod config for envoy upstreaming termination error (#4134) * add lifecycle * add preStop to api server's manifest * return makefile * Fix Fix parseComitMsg's comment (#4135) * Add kubectl version to stage log (#4137) * Add kubectl version to stage log * Update pkg/app/piped/executor/kubernetes/kubernetes.go Co-authored-by: knanao <[email protected]> Co-authored-by: knanao <[email protected]> * Add pipecd builtin tags to ECS resources (#4140) * Add tags to aws resources. * Small fix * Small fix * Fix initial slice length. * Add TagResource function * Fix deploy process * Add tags to aws resources. * Small fix * Small fix * Fix initial slice length. * Add TagResource function * Fix deploy process * Delete Unnecessary blank lines * Change how to add task's tags * Delete TagResource method * Fix based on linter * Apply review * add builtin-labels * Add tagResource func * Set default value of PropagateTags * Apply review * Apply review * Add upgrade a release method for helm (#4143) * tool: Replace set-output with GITHUB_OUTPUT (#4155) * Make all changes that not be listed in ignores but placed under appDir considered as touched commit (#4157) * Release v0.41.4 (#4161) * Release v0.41.4 * Update the release note --------- Co-authored-by: funera1 <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: kevin55156 <[email protected]> Co-authored-by: Tomoki Hori <[email protected]> Co-authored-by: Naoki Kanatani <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We can change image-tag every time when make run/pipecd, so we can see controller's change easily on kubernetes.
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: