Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get deployment's stage log from deployment-id #4158

Merged
merged 27 commits into from
Feb 13, 2023
Merged

Get deployment's stage log from deployment-id #4158

merged 27 commits into from
Feb 13, 2023

Conversation

funera1
Copy link
Member

@funera1 funera1 commented Feb 6, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4159

Does this PR introduce a user-facing change?:

NONE

@funera1 funera1 marked this pull request as draft February 6, 2023 08:42
@funera1 funera1 self-assigned this Feb 6, 2023
@funera1 funera1 marked this pull request as ready for review February 6, 2023 08:58
@funera1
Copy link
Member Author

funera1 commented Feb 6, 2023

Change to get stage log from deployment-id only

@knanao
Copy link
Member

knanao commented Feb 8, 2023

@funera1
Do you need to fix this?
This seems that you're still in the middle of fixing it.
If so, please make this WIP temporarily.

@funera1
Copy link
Member Author

funera1 commented Feb 8, 2023

Sorry. I will make this WIP temporarily.

@funera1 funera1 changed the title Get deployment's stage log from deployment-id and stage-id [WIP]Get deployment's stage log from deployment-id and stage-id Feb 8, 2023
@github-actions github-actions bot removed the area/web label Feb 10, 2023
@funera1 funera1 changed the title [WIP]Get deployment's stage log from deployment-id and stage-id [WIP]Get deployment's stage log from deployment-id Feb 10, 2023
@funera1 funera1 changed the title [WIP]Get deployment's stage log from deployment-id Get deployment's stage log from deployment-id Feb 10, 2023
@funera1 funera1 changed the title Get deployment's stage log from deployment-id [WIP]Get deployment's stage log from deployment-id Feb 13, 2023
funera1
funera1 commented Feb 13, 2023
View reviewed changes
pkg/app/server/service/apiservice/service.proto Outdated
message StageLog {
repeated model.LogBlock blocks = 1;
bool completed = 2;
string message = 3;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@funera1 funera1 changed the title [WIP]Get deployment's stage log from deployment-id Get deployment's stage log from deployment-id Feb 13, 2023
knanao
knanao reviewed Feb 13, 2023
View reviewed changes
pkg/app/pipectl/cmd/deployment/logs.go Show resolved Hide resolved
pkg/app/server/grpcapi/api.go Outdated Show resolved Hide resolved
@knanao
Copy link
Member

knanao commented Feb 13, 2023

@funera1
Please run make gen/code and push the generated file.

knanao
knanao approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@knanao knanao merged commit a63debd into master Feb 13, 2023
@knanao knanao deleted the add-pipectl-logs branch February 13, 2023 02:58
@github-actions github-actions bot mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knanao knanao knanao approved these changes

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202 khanhtc1202 is a code owner

Assignees

@funera1 funera1

Labels
area/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get deployment's stage logs from pipectl
2 participants
@funera1 @knanao