Fix unable to delete resource that removed from git for k8s apps #4207
Conversation
| for _, m := range manifests { | ||
| m.Key.Namespace = namespace | ||
| for i := range manifests { | ||
| manifests[i].Key.Namespace = namespace |
There was a problem hiding this comment.
I could understand what this wants to do, but originally the manifest is not a pointer, right?
There was a problem hiding this comment.
basically, this function accepts manifests which of type slice as it input. Go makes all function's input pass by value, thus it copy this manifests slide and manipulate thing inside the function. The point to note here is that even it copy the slide, the underlying array of that slide is remained to be the same, so basically change "that" array will change after function returns. Previously, instead of change the underlying array, m is a temporary var that ref to element of slide and change make on it does not reflect on the underlying array thus the changes are not remained after function end. And it doesn't matter the underlying array is of type pointer or not, this playground is an example.
There was a problem hiding this comment.
Oh, I totally understand. Thank you.
What this PR does / why we need it:
Previously due to this wrong iteration make changed via
setNamespacedoes not returned after loader.LoadManifests run, thus annotation and logic which based on manifest.ResourceKey.Namespace go wrong wayFrom
To
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: