Small changes on refactor APIKeyLastUseCache get #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knanao
reviewed
Feb 22, 2023
pkg/app/ops/apikeylastusedtimeupdater/apikeylastusedtimeupdater.go
Outdated
Show resolved
Hide resolved
pkg/app/ops/apikeylastusedtimeupdater/apikeylastusedtimeupdater.go
Outdated
Show resolved
Hide resolved
…r.go Co-authored-by: knanao <[email protected]>
…r.go Co-authored-by: knanao <[email protected]>
knanao
reviewed
Feb 23, 2023
pkg/app/server/grpcapi/web_api.go
Outdated
Comment on lines
1532
to
1533
| if cachedLastUse, err := a.apiKeyLastUsedStore.Get(apiKeys[i].Id); err == nil { | ||
| lastUsedAt, err = strconv.ParseInt(string(cachedLastUse.([]byte)), 10, 64) |
There was a problem hiding this comment.
[nits] This is also the same.
Suggested change
| if cachedLastUse, err := a.apiKeyLastUsedStore.Get(apiKeys[i].Id); err == nil { | |
| lastUsedAt, err = strconv.ParseInt(string(cachedLastUse.([]byte)), 10, 64) | |
| if cachedLastUse, err := a.apiKeyLastUsedStore.Get(apiKeys[i].Id); err == nil { | |
| s := string(cachedLastUse.([]byte) | |
| lastUsedAt, err = strconv.ParseInt(s, 10, 64) |
pkg/app/server/grpcapi/web_api.go
Outdated
| if cachedLastUse, err := a.apiKeyLastUsedStore.Get(apiKeys[i].Id); err == nil { | ||
| lastUsedAt, err = strconv.ParseInt(string(cachedLastUse.([]byte)), 10, 64) | ||
| if err != nil { | ||
| a.logger.Error("failed to get last used time from cache", zap.Error(err)) |
There was a problem hiding this comment.
Suggested change
| a.logger.Error("failed to get last used time from cache", zap.Error(err)) | |
| a.logger.Error("failed to parse last used time from cache", zap.Error(err)) |
pkg/app/server/grpcapi/web_api.go
Outdated
| lastUsedAt, err = strconv.ParseInt(string(cachedLastUse.([]byte)), 10, 64) | ||
| if err != nil { | ||
| a.logger.Error("failed to get last used time from cache", zap.Error(err)) | ||
| } |
There was a problem hiding this comment.
We should check the 1532 line's error?
There was a problem hiding this comment.
Sure do, I updated this part 🙆♀️
knanao
reviewed
Feb 24, 2023
Co-authored-by: knanao <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Follow #4201
Does this PR introduce a user-facing change?: