Fix unable to plan deployment on failed to determine app version #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, these functions re-used
errvariable, which defined in function signature. That make the caller side always return failed in case we can't determine the application version (which only be used in showing stub). The right behaviour should be only show versionunknownand keep deploying as usual.ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/controller/planner.go#L211-L214
Thanks @kevin55156 for pointing out this 👍
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: