Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnableApplication rpc for grpc api service #4274

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

kurochan
Copy link
Contributor

What this PR does / why we need it:
Support enable application operation through grpc api.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Add EnableApplication rpc for grpc api service

@khanhtc1202
Copy link
Member

khanhtc1202 commented Mar 16, 2023

Hi @kurochan thanks for your contribution 😁
Could you share the purpose of this PR? Since this PR only add rpc to grpc api (backend to handle pipectl request) we need to add pipectl imp as the caller side if you want to use this rpc 👀

fyi, this is the pipectl caller side impl for disable apps command
https://github.com/pipe-cd/pipecd/blob/master/pkg/app/pipectl/cmd/application/disable.go

@kurochan
Copy link
Contributor Author

@khanhtc1202 I'm trying to developing terraform provider for pipecd. In the process of that, I found there are no function to enable applications.

Should I implement pipectl command in this PR?

@khanhtc1202
Copy link
Member

I'm trying to developing terraform provider for pipecd. In the process of that, I found there are no function to enable applications.

I see, if you plan to connect to this rpc directly (not via pipectl) then it's fine to not implement pipectl command.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌

@khanhtc1202 khanhtc1202 merged commit 4e75740 into pipe-cd:master Mar 16, 2023
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants