Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fmt.Errorf to log.Fatal #4435

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

seipan
Copy link
Contributor

@seipan seipan commented Jun 25, 2023

What this PR does / why we need it:
Refactored because it was notated with fmt.Errorf and os.Exit instead of log.Fatal
Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks 👍

@khanhtc1202 khanhtc1202 merged commit 74fca69 into pipe-cd:master Jun 25, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants