Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GA4 data is not sent #4468

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix GA4 data is not sent #4468

merged 1 commit into from
Jul 7, 2023

Conversation

kentakozuka
Copy link
Member

What this PR does / why we need it:

According to docs, async script is no suitable for GA4.

Which issue(s) this PR fixes:

Fixes

Does this PR introduce a user-facing change?:

  • Is this breaking change:
  • How to migrate (if breaking change):
  • How are users affected by this change:

Signed-off-by: Kenta Kozuka <[email protected]>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look neat to me 👍

@kentakozuka kentakozuka merged commit 8ea515a into pipe-cd:master Jul 7, 2023
@kentakozuka kentakozuka deleted the fix-ga4 branch July 7, 2023 01:06
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants