-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to model/notificationevent #4631
Add tests to model/notificationevent #4631
Conversation
pkg/model/notificationevent_test.go
Outdated
func TestGroup(t *testing.T) { | ||
tests := []struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add t.Parallel
👍
pkg/model/notificationevent_test.go
Outdated
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
e := NotificationEvent{Type: tt.typ} | ||
got := e.Group() | ||
assert.Equal(t, tt.want, got) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be better to add t.Parallel
and assign a value as tt := tt
👀
for _, tt := range tests { | |
t.Run(tt.name, func(t *testing.T) { | |
e := NotificationEvent{Type: tt.typ} | |
got := e.Group() | |
assert.Equal(t, tt.want, got) | |
}) | |
for _, tt := range tests { | |
tt := tt | |
t.Run(tt.name, func(t *testing.T) { | |
t.Parallel() | |
e := NotificationEvent{Type: tt.typ} | |
got := e.Group() | |
assert.Equal(t, tt.want, got) | |
}) |
f3ec576
to
0c36131
Compare
@ffjlabo Fixed 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4631 +/- ##
==========================================
+ Coverage 30.55% 30.61% +0.06%
==========================================
Files 221 221
Lines 25937 25937
==========================================
+ Hits 7925 7941 +16
+ Misses 17363 17348 -15
+ Partials 649 648 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding test!!
Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
0c36131
to
4c69e15
Compare
* Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]>
* Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]>
* Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]>
* Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]>
* Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]>
#4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 (#4669) * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-plan-preview (#4611) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-gh-release (#4612) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <[email protected]> * Bump golang.org/x/net from 0.8.0 to 0.17.0 (#4613) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0. - [Commits](golang/net@v0.8.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/traverse from 7.14.7 to 7.23.2 in /web (#4619) * Fix part of lint/go errors (misspell, depguard, unconvert) (#4621) * Fix lint/go errors (misspell) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (unconvert) Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Fix part of lint/go errors (goimports, staticcheck, gosimple) (#4622) * Fix lint/go errors (goimport) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (staticcheck) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <[email protected]> * Fix return error by function Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Fix part of lint/go errors (deadcode, ineffassign, depguard) (#4624) * Ignore mannwhitney from golangci-lint Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (deadcode) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Add tests to terraform platform provider (#4625) Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to apikey model (#4626) Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to application model (#4627) Signed-off-by: Kenta Kozuka <[email protected]> * Reduce `make lint/go` execution time by adding the GOCACHE environment variable (#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Add tests to model/deployment (#4629) Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to model/deployment_chain (#4632) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 (#4633) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.54.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Update grpc test version Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: khanhtc1202 <[email protected]> * Fix lint/go errors (gocritic) (#4637) Signed-off-by: karamaru-alpha <[email protected]> * Fix part of lint/go errors (stylecheck) (#4638) * Fix lint/go errors (stylecheck) Signed-off-by: karamaru-alpha <[email protected]> * Remove nolint:stylecheck Signed-off-by: karamaru-alpha <[email protected]> * Change method reveiver name Signed-off-by: karamaru-alpha <[email protected]> * Change receiver name k to ak Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Bump github.com/docker/docker (#4641) * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> * Fix panic error in ListDeployments API (#4650) * Update golangci-lint and fix lint errors (#4656) Signed-off-by: karamaru-alpha <[email protected]> * Send error comment before plan preview exit (#4658) * Send error comment before plan preview exit Signed-off-by: Takumaron <[email protected]> * Apply review commnet Signed-off-by: Takumaron <[email protected]> --------- Signed-off-by: Takumaron <[email protected]> * Handle plan preview workflow's error and exit with error status code (#4662) * Add a flag to skip running standalone task during deployment (#4666) * Add a flag to skip running standalone task during deployment Signed-off-by: Kenta Kozuka <[email protected]> * Fix docs Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: karamaru-alpha <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Takumaron <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: karamaru <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: khanhtc1202 <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Seitaro Fujigaki <[email protected]> Co-authored-by: Kurosawa Takuma <[email protected]>
* Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]>
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
* feat(ECS): enable selection of listener rules (#4668) * feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> * Remove ModifyRules interface (#4688) --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Shun Takahashi <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
* Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]>
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
* Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]>
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
* Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: sZma5a <[email protected]>
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Signed-off-by: sZma5a <[email protected]>
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Signed-off-by: sZma5a <[email protected]>
* Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
* Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
* feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <[email protected]> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <[email protected]> * Make actions plan preview handle timeout option (pipe-cd#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (pipe-cd#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: moko-poi <[email protected]> * Increase limit of stale action operations (pipe-cd#4671) Signed-off-by: moko-poi <[email protected]> * Add docs for k8s annotations (pipe-cd#4673) Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: moko-poi <[email protected]> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <[email protected]> * fix: ModifyRules Signed-off-by: moko-poi <[email protected]> * fix: rollback Signed-off-by: moko-poi <[email protected]> * fix: routing Signed-off-by: moko-poi <[email protected]> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <[email protected]> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <[email protected]> --------- Signed-off-by: moko-poi <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: