Implement gRPC service for envoy ExtAuthz #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada <[email protected]>
Signed-off-by: Shinnosuke Sawada <[email protected]>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Signed-off-by: Shinnosuke Sawada <[email protected]>
…possible Signed-off-by: Shinnosuke Sawada <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4990 +/- ##
==========================================
+ Coverage 22.04% 22.45% +0.40%
==========================================
Files 519 520 +1
Lines 57247 56852 -395
==========================================
+ Hits 12621 12766 +145
+ Misses 43604 43060 -544
- Partials 1022 1026 +4 ☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Jun 24, 2024
| @@ -0,0 +1,68 @@ | |||
| package grpcapi | |||
There was a problem hiding this comment.
Please add the pipecd license header (refer other files)
There was a problem hiding this comment.
Thanks. I added this commit: 6ed9c7a.
Signed-off-by: Shinnosuke Sawada <[email protected]>
|
Overall LGTM, just left a nits about licensing |
ffjlabo
reviewed
Jul 2, 2024
Comment on lines
72
to
82
| func (e *EnvoyAuthorizationServer) parsePipedToken(a string) (string, string, string, error) { | ||
| if !strings.HasPrefix(a, "Bearer ") { | ||
| return "", "", "", errors.New("invalid authorization header") | ||
| } | ||
|
|
||
| parts := strings.Split(strings.TrimPrefix(a, "Bearer "), ",") | ||
| if len(parts) != 3 || parts[0] == "" || parts[1] == "" || parts[2] == "" { | ||
| return "", "", "", errors.New("malformed piped token") | ||
| } | ||
| return parts[0], parts[1], parts[2], nil | ||
| } |
There was a problem hiding this comment.
[IMO] It might be nice to use parsePipedToken in rpc/rpcauth WDYT?
https://github.com/pipe-cd/pipecd/blob/ce05395afbd2397e60a7a9b99cb6c4d3fad07294/pkg/rpc/rpcauth/auth.go#L55C1-L77C2
There was a problem hiding this comment.
Thank you!
That sounds nice! I'll change the codes.
There was a problem hiding this comment.
I fixed the codes.
|
@Warashi DCO not pass 👀 |
Signed-off-by: Shinnosuke Sawada <[email protected]>
Signed-off-by: Shinnosuke Sawada <[email protected]>
Warashi
force-pushed
the
envoy-ext-authz-service
branch
from
6049c0f
to
0093830
Compare
|
@khanhtc1202 |
Merged
khanhtc1202
pushed a commit
that referenced
this pull request
Jul 12, 2024
* Implement gRPC service for envoy ExtAuthz Signed-off-by: Shinnosuke Sawada <[email protected]> * Run gRPC server for envoy ExtAuthz Signed-off-by: Shinnosuke Sawada <[email protected]> * Add words to make document clear Signed-off-by: Shinnosuke Sawada <[email protected]> * Change dependency versions as which match current we uses as much as possible Signed-off-by: Shinnosuke Sawada <[email protected]> * Add License header Signed-off-by: Shinnosuke Sawada <[email protected]> * Expose parsePipedToken to use at envoy grpc auth service Signed-off-by: Shinnosuke Sawada <[email protected]> * Use rpcauth.ParsePipedToken instead of implementing in package Signed-off-by: Shinnosuke Sawada <[email protected]> --------- Signed-off-by: Shinnosuke Sawada <[email protected]> Signed-off-by: khanhtc1202 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements envoy external authorization service with gRPC, as RFC.
After merging this PR, I'll send another PR to add routing to the envoy configuration.
Which issue(s) this PR fixes:
Part of #4977
Does this PR introduce a user-facing change?: No