Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install jq in piped-base images #5009

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Install jq in piped-base images #5009

merged 1 commit into from
Jul 1, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Jul 1, 2024

What this PR does / why we need it:

This PR installs jq to the piped-base images.

PR #5002 introduces environment variables in the SCRIPT_RUN stage.
One of these environment variables has JSON format, so we need jq to deal with it.
After merging this PR, we need to update other Dockefiles to use new piped-base images.

Which issue(s) this PR fixes:

Part of #4814

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada <[email protected]>
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.25%. Comparing base (ce9bc16) to head (37368f7).
Report is 222 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5009      +/-   ##
==========================================
- Coverage   22.25%   22.25%   -0.01%     
==========================================
  Files         519      519              
  Lines       57234    57234              
==========================================
- Hits        12739    12735       -4     
- Misses      43468    43471       +3     
- Partials     1027     1028       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@Warashi Warashi enabled auto-merge (squash) July 1, 2024 01:17
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Warashi Warashi merged commit e20cd0b into master Jul 1, 2024
25 checks passed
@Warashi Warashi deleted the piped-base-image-jq branch July 1, 2024 01:50
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
khanhtc1202 pushed a commit that referenced this pull request Jul 12, 2024
Signed-off-by: Shinnosuke Sawada <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants