-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it clear to attach IAM policies to ECS task-role #5035
Conversation
Signed-off-by: t-kikuc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about removing this line?
pipecd/docs/content/en/docs-dev/installation/install-piped/required-permissions.md
Line 49 in 7ca5c05
"arn:aws:iam::<account-id>:role/<task-execution-role>", |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5035 +/- ##
=======================================
Coverage 22.42% 22.42%
=======================================
Files 522 522
Lines 56915 56915
=======================================
Hits 12766 12766
Misses 43123 43123
Partials 1026 1026 ☔ View full report in Codecov by Sentry. |
It’s mandatory. |
Sorry, I misread. As I understood, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Make it clear which role to attach IAM policies to because ECS's
task-role
andtask-execution-role
are confusing.