Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4 typos #5086

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Fix 4 typos #5086

merged 5 commits into from
Jul 30, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jul 28, 2024

What this PR does / why we need it:

Fixed 4 small typos:

  • 'aplication' -> 'application'
  • 'put from' -> 'put into'
  • 'to rolling out' -> 'to roll out'
  • 'service manifest' -> 'lambda function manifest'

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

@t-kikuc t-kikuc enabled auto-merge (squash) July 28, 2024 06:52
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

39

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 22.84%. Comparing base (46b475c) to head (a67ca38).

Files Patch % Lines
pkg/app/piped/executor/ecs/ecs.go 0.00% 3 Missing ⚠️
pkg/app/piped/executor/lambda/lambda.go 0.00% 1 Missing ⚠️
pkg/app/piped/platformprovider/cloudrun/cache.go 0.00% 1 Missing ⚠️
pkg/app/piped/platformprovider/kubernetes/cache.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5086   +/-   ##
=======================================
  Coverage   22.84%   22.84%           
=======================================
  Files         409      409           
  Lines       43300    43300           
=======================================
  Hits         9891     9891           
  Misses      32630    32630           
  Partials      779      779           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t-kikuc t-kikuc merged commit 47ac7e1 into master Jul 30, 2024
17 of 18 checks passed
@t-kikuc t-kikuc deleted the fix-typos branch July 30, 2024 05:28
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants