-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Lambda config docs #5087
Fix Lambda config docs #5087
Conversation
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5087 +/- ##
==========================================
- Coverage 22.84% 22.83% -0.01%
==========================================
Files 409 409
Lines 43300 43300
==========================================
- Hits 9891 9889 -2
- Misses 32630 32633 +3
+ Partials 779 778 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch 👍
… function.go Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
What this PR does / why we need it:
Fix Lambda config docs in the configuration-reference.
The main changes are:
ImageURI
->image
SecurityGroupIDs
->securityGroupIds
SubnetIDs
->subnetIds
SourceCode
->source
[edited in 709ac39]Required
values and add explanationsFor Reviewers
See function.go.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: no