Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #5037 #5038 #5039 #5040 #5063 #5065 #5070 #5072 #5090 #5091

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Jul 29, 2024

What this PR does / why we need it:
Cherry pick of #5037 #5038 #5039 #5040 #5063 #5065 #5070 #5072 #5090.

khanhtc1202 and others added 9 commits July 29, 2024 12:45
Snyk has created this PR to upgrade dotenv from 8.2.0 to 8.6.0.

See this package in yarn:
dotenv

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Snyk has created this PR to upgrade @types/yup from 0.29.11 to 0.29.14.

See this package in yarn:
@types/yup

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Snyk has created this PR to upgrade react-draggable from 4.4.3 to 4.4.6.

See this package in yarn:
react-draggable

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Snyk has created this PR to upgrade clsx from 1.1.1 to 1.2.1.

See this package in yarn:
clsx

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
* yarn remove @date-io/dayjs

Signed-off-by: t-kikuc <[email protected]>

* yarn remove @material-ui/pickers

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that this PR includes #5063, the only one issue in the v0.48.3 board.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@t-kikuc t-kikuc enabled auto-merge (squash) July 29, 2024 04:28
@t-kikuc
Copy link
Member

t-kikuc commented Jul 29, 2024

I reopen this PR to trigger tests. (maybe solved by #5094)

@t-kikuc t-kikuc closed this Jul 29, 2024
auto-merge was automatically disabled July 29, 2024 05:01

Pull request was closed

@t-kikuc t-kikuc reopened this Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.52%. Comparing base (be5d908) to head (0930bab).
Report is 1 commits behind head on release-v0.48.x.

Files Patch % Lines
pkg/app/piped/platformprovider/ecs/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-v0.48.x    #5091      +/-   ##
===================================================
+ Coverage            22.49%   22.52%   +0.02%     
===================================================
  Files                  520      519       -1     
  Lines                56993    56912      -81     
===================================================
- Hits                 12822    12818       -4     
+ Misses               43144    43066      -78     
- Partials              1027     1028       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc merged commit 57805c1 into release-v0.48.x Jul 29, 2024
17 of 18 checks passed
@t-kikuc t-kikuc deleted the cherry-pick-#5037-#5038-#5039-#5040-#5063-#5065-#5070-#5072-#5090-to-release-v0.48.x branch July 29, 2024 05:06
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants