Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Otel traces to the control plane. #5092

Merged
merged 11 commits into from
Aug 29, 2024
Merged

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Jul 29, 2024

What this PR does / why we need it:

  • Add trace spans for the plan and deployment.
  • Add default attributes for tracing.
  • Disable opentelemetry-collector routes when monitoring isn't enabled.

This is the sample trace sent to the local Jaeger by this implementation.
the sent traces to the local Jaeger

Which issue(s) this PR fixes:

Part of #4977

The rest are below.

  • add documents.
  • add the component to visualize traces.

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 7.00000% with 186 lines in your changes missing coverage. Please review.

Project coverage is 22.76%. Comparing base (f89dd9a) to head (c016886).
Report is 56 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 55 Missing ⚠️
pkg/app/pipedv1/controller/scheduler.go 0.00% 45 Missing ⚠️
pkg/app/piped/controller/scheduler.go 0.00% 44 Missing ⚠️
pkg/app/piped/cmd/piped/piped.go 0.00% 21 Missing ⚠️
pkg/app/piped/controller/planner.go 0.00% 14 Missing ⚠️
pkg/app/pipedv1/controller/planner.go 0.00% 3 Missing ⚠️
pkg/app/piped/controller/tracing.go 77.77% 2 Missing ⚠️
pkg/app/pipedv1/controller/tracing.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5092      +/-   ##
==========================================
- Coverage   22.82%   22.76%   -0.06%     
==========================================
  Files         409      414       +5     
  Lines       43338    44044     +706     
==========================================
+ Hits         9891    10027     +136     
- Misses      32668    33228     +560     
- Partials      779      789      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as draft July 29, 2024 04:47
@Warashi
Copy link
Contributor Author

Warashi commented Jul 29, 2024

I found some needs for refactoring, so I changed this PR's state to a draft.

→ completed

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi Warashi marked this pull request as ready for review July 29, 2024 05:23
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Co-authored-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi Warashi requested a review from ffjlabo August 28, 2024 04:25
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Warashi Warashi merged commit 6a432ed into master Aug 29, 2024
16 of 18 checks passed
@Warashi Warashi deleted the otel-trace-export-piped-traces branch August 29, 2024 23:58
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants