Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As title.
Since avatar images are not shown on the header for OIDC users, users want to know which account they logged in to.
GitHub: GitHub user ID
OIDC: username from IdP
I think
role
is not necessary to show.Which issue(s) this PR fixes:
Related to #5008
See #5008 (comment)
Does this PR introduce a user-facing change?: Users can see their username.
For Reviewers
See here to understand why
subject
is used.pipecd/pkg/app/server/httpapi/callback.go
Lines 92 to 103 in 0340541