Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document for force-sync-by-replace annotation #5179

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 3, 2024

What this PR does / why we need it:

Add documentation of force-sync-by-replace annotation.

Which issue(s) this PR fixes:

Fixes #5174
Follows #5175

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.90%. Comparing base (e9dd4c5) to head (569baac).
Report is 25 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5179   +/-   ##
=======================================
  Coverage   22.90%   22.90%           
=======================================
  Files         416      416           
  Lines       44690    44690           
=======================================
  Hits        10238    10238           
  Misses      33660    33660           
  Partials      792      792           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this after releasing #5175.

because users cannot use the annotation in v0.48.x yet.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi merged commit 8e62937 into master Sep 10, 2024
17 checks passed
@Warashi Warashi deleted the force-sync-by-replace-document branch September 10, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support kubectl replace with force option
4 participants