Fix docs for rc patch release #5180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka,
t-kikuc and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5180 +/- ##
==========================================
- Coverage 22.90% 22.89% -0.01%
==========================================
Files 416 416
Lines 44690 44690
==========================================
- Hits 10238 10234 -4
- Misses 33660 33663 +3
- Partials 792 793 +1 ☔ View full report in Codecov by Sentry. |
t-kikuc
previously approved these changes
Sep 3, 2024
khanhtc1202
reviewed
Sep 3, 2024
RELEASES.md
Outdated
| 1. Move on to [Releases > Draft a New Release](https://github.com/pipe-cd/pipecd/releases/new). | ||
| 2. Set values as below: | ||
|
|
||
| 1. (Only for the patch rc release) At first, we need to cherry-pick the fixes to the release branch. Please refer to [Backport fixes and Release note](https://github.com/pipe-cd/pipecd/blob/master/RELEASES.md#backport-fixes-and-release-note) |
There was a problem hiding this comment.
Suggested change
| 1. (Only for the patch rc release) At first, we need to cherry-pick the fixes to the release branch. Please refer to [Backport fixes and Release note](https://github.com/pipe-cd/pipecd/blob/master/RELEASES.md#backport-fixes-and-release-note) | |
| 1. Prepare: Ensure all changes you want to attach to the release are available in the release target branch (`master` for the minor, `release-vX.Y.x` for the patch). Please refer to [Backport fixes and Release note](#backport-fixes-and-release-note) |
how about this?
There was a problem hiding this comment.
@khanhtc1202
Thanks, It looks totally nice.
Backport fixes and Release note is about cherry-pick process and need only for the patch release.
So how about this? Just added a little change.
Prepare: Ensure all changes you want to attach to the release are available in the release target branch (`master` for the minor, `release-vX.Y.x` for the patch). For the patch, please refer to [Backport fixes and Release note](#backport-fixes-and-release-note)
There was a problem hiding this comment.
@ffjlabo thanks, it looks better 👍
Signed-off-by: Yoshiki Fujikane <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
as title
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: