Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route to opentelemetry collector at the ingress #5187

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 4, 2024

What this PR does / why we need it:

Add a route to the pipecd-gateway for the OpenTelemetry Collector path.

Which issue(s) this PR fixes:

Follows #5016
Fixes #4977

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.93%. Comparing base (b4cc0e8) to head (7e5c348).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5187   +/-   ##
=======================================
  Coverage   22.93%   22.93%           
=======================================
  Files         419      419           
  Lines       44986    44986           
=======================================
  Hits        10318    10318           
  Misses      33873    33873           
  Partials      795      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi enabled auto-merge (squash) September 4, 2024 08:26
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Warashi Warashi merged commit a12ab46 into master Sep 4, 2024
17 checks passed
@Warashi Warashi deleted the otel-collector-path-ingress branch September 4, 2024 08:39
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the way to export the deployment traces.
3 participants