Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the envoy retry policy for external-authz filter #5194

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Set the envoy retry policy for external-authz filter #5194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0c6450
Add timeout for envoy ext_authz
Warashi Sep 6, 2024
1bbce13
Upgrade envoy
Warashi Sep 6, 2024
e329ae8
Set retry_policy for ext_authz service
Warashi Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/pipecd/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
{{- end }}
containers:
- name: envoy
image: envoyproxy/envoy-alpine:{{ .Values.gateway.imageTag }}
image: envoyproxy/envoy:{{ .Values.gateway.imageTag }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

envoy-alpine has stopped updating 2 years ago

imagePullPolicy: IfNotPresent
command:
- envoy
Expand Down
13 changes: 13 additions & 0 deletions manifests/pipecd/templates/envoy-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,31 @@ data:
grpc_service:
envoy_grpc:
cluster_name: grpc-envoy-ext-authz
retry_policy:
num_retries: 3
retry_back_off:
base_interval: 0.25s
max_interval: 1s
retry_on: 5xx
timeout: 3s
transport_api_version: V3
include_peer_certificate: false
- name: envoy.filters.http.grpc_web
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.http.grpc_web.v3.GrpcWeb
{{- if .Values.cors.enabled }}
- name: envoy.filters.http.cors
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.http.cors.v3.Cors
{{- end }}
- name: envoy.filters.http.grpc_stats
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.http.grpc_stats.v3.FilterConfig
stats_for_all_methods: true
enable_upstream_stats: true
- name: envoy.filters.http.router
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
Comment on lines +51 to +65
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to set these to bump the envoy version

route_config:
name: local_route
virtual_hosts:
Expand Down
2 changes: 1 addition & 1 deletion manifests/pipecd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ serviceAccount:
# Workloads.
gateway:
replicasCount: 1
imageTag: v1.18.3
imageTag: v1.31.0
resources: {}
internalTLS:
enabled: false
Expand Down
Loading