Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable the persistence of the Grafana Tempo" #5209

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 12, 2024

Reverts #5208

After merging the above PR, Grafana Tempo's pod becomes CrashLoopBackOff in the dev environment.
The logs say there is a permission issue of persistent volume.

{"caller":"main.go:121","err":"failed to init module services: error initialising module: store: failed to create store: mkdir /var/tempo/traces: permission denied","level":"error","msg":"error running Tempo","ts":"2024-09-12T09:24:39.054661796Z"}                                                                                                                    

I think we have encountered this issue.
grafana/helm-charts#3197

This reverts commit 41ae6d1.

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi Warashi force-pushed the revert-5208-grafana-tempo-persistent-volume branch from fbf0eb0 to 3fee9f2 Compare September 12, 2024 09:18
@Warashi
Copy link
Contributor Author

Warashi commented Sep 12, 2024

I could not reproduce this issue with my local kind cluster so that it may depend on the storage backend.
This means it's challenging to prepare a generic workaround, I think.
I want to revert those changes and use container-local storage as a default option.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.83%. Comparing base (41ae6d1) to head (3fee9f2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5209   +/-   ##
=======================================
  Coverage   22.83%   22.83%           
=======================================
  Files         420      420           
  Lines       45302    45302           
=======================================
  Hits        10344    10344           
  Misses      34163    34163           
  Partials      795      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi merged commit 2d089a8 into master Sep 12, 2024
17 checks passed
@Warashi Warashi deleted the revert-5208-grafana-tempo-persistent-volume branch September 12, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants