Fix to use target dsp in script run rollback #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffjlabo
commented
Sep 17, 2024
| @@ -90,7 +90,7 @@ func (p *provider) Get(ctx context.Context, lw io.Writer) (*DeploySource, error) | |||
|
|
|||
| if !p.done { | |||
| p.source, p.err = p.prepare(ctx, lw) | |||
| p.done = true | |||
| p.done = p.err == nil // If there is an error, we should re-prepare it next time. | |||
There was a problem hiding this comment.
📝 This modification is necessary to avoid an error when executing a cancellation while executing TargetDSP.Get in another stage.
I encountered such a situation when canceling the deployment via WebUI during the SCRIPT_RUN stage execution like this↓.
There was a problem hiding this comment.
I split the fixes to the another PR #5216
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5215 +/- ##
=======================================
Coverage 22.82% 22.82%
=======================================
Files 420 420
Lines 45302 45309 +7
=======================================
+ Hits 10340 10344 +4
- Misses 34166 34170 +4
+ Partials 796 795 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
force-pushed
the
fix-to-use-target-dsp-in-script-run-rollback
branch
from
2d270a4
to
6aa0a06
Compare
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka,
t-kikuc and
Warashi
as code owners
ffjlabo
force-pushed
the
fix-to-use-target-dsp-in-script-run-rollback
branch
from
8ffadca
to
a936845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixed to use TargetDSP on the SCRIPT_RUN_ROLLBACK stage.
With these fixes, we can refer to the files located in the app dir when executing the SCRIPT_RUN_ROLLBACK stage.
I chose TargetDSP, not RunningDSP, because the commands on the
onRollbackare set in app.pipecd.yaml used when Deployment is executed.The purpose of the SCRIPT_RUN_ROLLBACK stage is to run whatever command is currently set in onRollback during rollback.
Which issue(s) this PR fixes:
Part of #5214
Does this PR introduce a user-facing change?: