Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolregistry client as DeploymentService member #5228

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 26, 2024

What this PR does / why we need it:

as title

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1 only

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 22.92%. Comparing base (c3386cf) to head (da5b80a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...kg/app/pipedv1/plugin/toolregistry/toolregistry.go 0.00% 10 Missing ⚠️
...app/pipedv1/plugin/kubernetes/deployment/server.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5228   +/-   ##
=======================================
  Coverage   22.91%   22.92%           
=======================================
  Files         419      420    +1     
  Lines       45321    45332   +11     
=======================================
+ Hits        10385    10391    +6     
- Misses      34139    34144    +5     
  Partials      797      797           
Flag Coverage Δ
22.92% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi merged commit e9e076d into master Sep 26, 2024
16 of 17 checks passed
@Warashi Warashi deleted the pipedv1-k8s-plugin branch September 26, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants