Add test for k8s plugin's toolregistry #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5246 +/- ##
==========================================
+ Coverage 23.96% 24.05% +0.09%
==========================================
Files 438 439 +1
Lines 47017 46957 -60
==========================================
+ Hits 11267 11297 +30
+ Misses 34846 34756 -90
Partials 904 904
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Oct 1, 2024
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package toolregistry_test |
There was a problem hiding this comment.
we usually not create test package, just keep it package toolregistry
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
khanhtc1202
reviewed
Oct 1, 2024
pkg/app/pipedv1/plugin/toolregistry/toolregistrytest/toolregistrytest.go
Show resolved
Hide resolved
t-kikuc
approved these changes
Oct 2, 2024
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: