Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #5240 #5241 #5248 #5249 #5254 #5255 #5256 #5258 #5260 #5262 #5263 #5265

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 8, 2024

What this PR does / why we need it:
Cherry pick of #5240 #5241 #5248 #5249 #5254 #5255 #5256 #5258 #5260 #5262 #5263.

t-kikuc and others added 11 commits October 8, 2024 05:15
… exist (#5240)

* Generate v0.49.x docs

Signed-off-by: t-kikuc <[email protected]>

* fix: avoid panic when live taskdef does not exist

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
* Generate v0.49.x docs

Signed-off-by: t-kikuc <[email protected]>

* upgrade aws-sdk-go-v2

Signed-off-by: t-kikuc <[email protected]>

* upgrade aws-sdk-go-v2/**/*

Signed-off-by: t-kikuc <[email protected]>

* fix compile errors caused by the breaking change

Signed-off-by: t-kikuc <[email protected]>

* fix a test due to added RestartPolicy

Signed-off-by: t-kikuc <[email protected]>

* fix: avoid panic when live taskdef does not exist

Signed-off-by: t-kikuc <[email protected]>

* fix go.sum by `make update/go-deps`

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
* Generate v0.49.x docs

Signed-off-by: t-kikuc <[email protected]>

* remove unused field 'configFilePathInGitRepo'

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
* Generate v0.49.x docs

Signed-off-by: t-kikuc <[email protected]>

* add --aws-ssm-parameter

Signed-off-by: t-kikuc <[email protected]>

* add config-aws-ssm-parameter to piped

Signed-off-by: t-kikuc <[email protected]>

* update docs of runtime options

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: HoangNguyen689 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
…#5258)

* Generate v0.49.x docs

Signed-off-by: t-kikuc <[email protected]>

* add --git-ssh-key-env

Signed-off-by: t-kikuc <[email protected]>

* update docs: add '--git-ssh-key-env'

Signed-off-by: t-kikuc <[email protected]>

* add '\n' at the end of ssh key

Signed-off-by: t-kikuc <[email protected]>

* Directly use data instead of env

Signed-off-by: t-kikuc <[email protected]>

* Clarify the flag description

Signed-off-by: t-kikuc <[email protected]>

* fix error message:  'and' -> 'or'

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
* update RELEASE to v0.49.1

Signed-off-by: t-kikuc <[email protected]>

* update docs of v0.49.x by `make release version=v0.49.1`

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 19.16667% with 97 lines in your changes missing coverage. Please review.

Project coverage is 22.80%. Comparing base (909fd76) to head (d02bac8).
Report is 1 commits behind head on release-v0.49.x.

Files with missing lines Patch % Lines
pkg/app/launcher/cmd/launcher/launcher.go 0.00% 64 Missing ⚠️
pkg/app/piped/cmd/piped/piped.go 6.06% 31 Missing ⚠️
pkg/app/piped/platformprovider/ecs/client.go 0.00% 1 Missing ⚠️
pkg/filestore/s3/s3.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-v0.49.x    #5265      +/-   ##
===================================================
- Coverage            22.82%   22.80%   -0.02%     
===================================================
  Files                  419      419              
  Lines                45304    45390      +86     
===================================================
+ Hits                 10340    10351      +11     
- Misses               34169    34244      +75     
  Partials               795      795              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t-kikuc t-kikuc merged commit fa404a8 into release-v0.49.x Oct 8, 2024
14 of 17 checks passed
@t-kikuc t-kikuc deleted the cherry-pick-#5240-#5241-#5248-#5249-#5254-#5255-#5256-#5258-#5260-#5262-#5263-to-release-v0.49.x branch October 8, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants