Fix the workflow publishes quickstart manifests #5266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
|
I found a better solution. I'll change the actions/checkout arguments, not the create-pull-request arguments. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5266 +/- ##
==========================================
- Coverage 24.09% 24.08% -0.01%
==========================================
Files 441 441
Lines 47099 47099
==========================================
- Hits 11348 11345 -3
- Misses 34847 34850 +3
Partials 904 904 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
t-kikuc
approved these changes
Oct 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Add pull-requests permission to the workflow Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Set the base branch to the default branch of the repository Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Use `github.ref_name` to determine the version of manifests Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Checkout master branch to make PR to master branch Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
t-kikuc
added a commit
that referenced
this pull request
Oct 9, 2024
* Fix the workflow publishes quickstart manifests (#5266) * Add pull-requests permission to the workflow Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Set the base branch to the default branch of the repository Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Use `github.ref_name` to determine the version of manifests Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> * Checkout master branch to make PR to master branch Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Remove pipectl quickstart command (#5268) * Remove pipectl quickstart command Signed-off-by: khanhtc1202 <[email protected]> * Remove the quickstart from docs Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Enabled to configure the interval of livestate store for Lambda (#5269) * add liveStateInterval for Lambda Signed-off-by: t-kikuc <[email protected]> * add docs of liveStateInterval Signed-off-by: t-kikuc <[email protected]> * fix a test Signed-off-by: t-kikuc <[email protected]> * Rename to 'awsAPIPollingInterval' Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Update RELEASE to v0.49.2 and sync docs of v0.49.x (#5272) Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: t-kikuc <[email protected]> Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Tetsuya Kikuchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ref; https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#token
ref; https://github.com/pipe-cd/pipecd/actions/runs/11229319582/job/31214779847#step:6:52
Which issue(s) this PR fixes:
Follow PR #5260
Does this PR introduce a user-facing change?: