Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove order for stages in case of quick sync #5292

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Oct 24, 2024

What this PR does:

Remove stages' order (indexes) if a quick sync deployment is triggered.

Why we need it:

Previously, we planned to make plugins' order as stages order in case of multi-plugin applications. However, it is difficult to decide the order of the application's plugins, and the application's plugins may change, so it is better not to depend on that.

Which issue(s) this PR fixes:

This reverts what we did in #5231 and #5229

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <[email protected]>
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) October 24, 2024 10:08
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.38%. Comparing base (cbbd67d) to head (c55a811).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/pipedv1/plugin/kubernetes/deployment/pipeline.go 66.66% 1 Missing ⚠️
...app/pipedv1/plugin/kubernetes/deployment/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5292      +/-   ##
==========================================
- Coverage   24.39%   24.38%   -0.01%     
==========================================
  Files         443      443              
  Lines       46941    46927      -14     
==========================================
- Hits        11453    11445       -8     
+ Misses      34577    34571       -6     
  Partials      911      911              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202 khanhtc1202 merged commit 4ebcb7c into master Oct 25, 2024
18 checks passed
@khanhtc1202 khanhtc1202 deleted the remove-quicksync-stage-order branch October 25, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants