Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore updating quickstart for rc release #5347

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Nov 19, 2024

What this PR does:

as title

Why we need it:

We decided not to update it when we released the RC version.
#5329 (comment)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.31%. Comparing base (23eddac) to head (237063d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5347      +/-   ##
==========================================
+ Coverage   25.29%   25.31%   +0.02%     
==========================================
  Files         444      444              
  Lines       47656    47669      +13     
==========================================
+ Hits        12053    12066      +13     
  Misses      34661    34661              
  Partials      942      942              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ffjlabo ffjlabo merged commit e3325a1 into master Nov 19, 2024
18 checks passed
@ffjlabo ffjlabo deleted the ignore-rc-for-updating-quickstart branch November 19, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants