Digitaldotsnl patch 1 #499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'Groene container' and 'Grijze container' to OmrinCollector WASTE_TYPE_MAPPING
Added two waste type mappings for OmrinCollector: Groene container and Grijze container.
|
Why do we need to add these mappings? It should work without these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Afvalbeheer did not return any data for my Omrin setup. Added two new waste types to OmrinCollector, according to what the printwastetypes message returned for my address (groene container and grijze container). Works after adding these and reloading the config.
Edit: sorry for the 3 commits, this was my first time creating a pull request and was figuring out how to do it.