Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect initialization ShardedCorpus with a generator. Fix #1511. #1512

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Fix incorrect initialization ShardedCorpus with a generator. Fix #1511. #1512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08dfb08
Fix initializing ShardedCorpus with a generator (#1511)
karkkainenk1 Jul 29, 2017
9f2a4e3
Merge branch 'develop' into fix-shardedcorpus-generator
menshikh-iv Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gensim/corpora/sharded_corpus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ def __init__(self, output_prefix, corpus, dim=None,
def init_shards(self, output_prefix, corpus, shardsize=4096, dtype=_default_dtype):
"""Initialize shards from the corpus."""

if not gensim.utils.is_corpus(corpus):
is_corpus, corpus = gensim.utils.is_corpus(corpus)
if not is_corpus:
raise ValueError(
"Cannot initialize shards without a corpus to read from! (Got corpus type: {0})".format(type(corpus))
)
Expand Down
12 changes: 12 additions & 0 deletions gensim/test/test_sharded_corpus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,18 @@ def test_resize(self):
fname = dataset._shard_name(n)
self.assertTrue(os.path.isfile(fname))

def test_init_with_generator(self):

def data_generator():
yield [(0, 1)]
yield [(1, 1)]

gen_tmp_fname = self.tmp_fname + '.generator'
corpus = ShardedCorpus(gen_tmp_fname, data_generator(), dim=2)

self.assertEqual(2, len(corpus))
self.assertEqual(1, corpus[0][0])


if __name__ == '__main__':
suite = unittest.TestSuite()
Expand Down