Fix deprecated parameters in D2VTransformer and W2VTransformer. Fix #1937
#1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename `size` and `iter` to `vector_size` and `epochs` in sklearn_api doc2vec wrapper
rename `size` and `iter` to `vector_size` and `epochs` in sklearn_api word2vec wrappers
menshikh-iv
suggested changes
Feb 28, 2018
| """ | ||
| Sklearn api for Doc2Vec model. See gensim.models.Doc2Vec and gensim.models.Word2Vec for parameter details. | ||
| """ | ||
|
|
||
| if size is not None: |
There was a problem hiding this comment.
Are you sure that this is the best way to make it?
menshikh-iv
changed the title
D2VTransformer and W2VTransformer. Fix #1937
|
@swierh should we add |
|
Continued in #1945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1937
Renamed
iterandsizearguments toepochsandvector_sizein the following two wrappers:gensim.sklearn_api.d2vmodelandgensim.sklearn_api.w2vmodel.Added deprecation warnings for use of
iterandsize.