Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backward compatibility issue: loading FastTextKeyedVectors using KeyedVectors (missing attribute compatible_hash) #2349

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Fix backward compatibility issue: loading FastTextKeyedVectors using KeyedVectors (missing attribute compatible_hash) #2349

merged 3 commits into from
Jan 23, 2019

Conversation

menshikh-iv
Copy link
Contributor

Fix #2341

CC: @akutuzov, if you have a time, can you check, is current PR fix your problem (I already added an test, just to be fully sure)?

@akutuzov
Copy link
Contributor

@menshikh-iv yes it does.

@menshikh-iv menshikh-iv merged commit 95e222a into develop Jan 23, 2019
@menshikh-iv menshikh-iv deleted the fix-backward-compat-with-kv branch January 23, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fastText fixes in 3.7 break compatibility with old models
2 participants
@menshikh-iv @akutuzov