Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out process_result_queue from cycle in LdaMulticore #2358

Merged
merged 4 commits into from
Jan 29, 2019
Merged

Move out process_result_queue from cycle in LdaMulticore #2358

merged 4 commits into from
Jan 29, 2019

Conversation

horpto
Copy link
Contributor

@horpto horpto commented Jan 28, 2019 •
edited
Loading

  • simplify inner check
  • add heuristic for case with large number of workers

@horpto
Move out process_result_queue
f61219e 
+ simplify inner check
+ add heuristic for case with large number of workers
@horpto
Copy link
Contributor Author

horpto commented Jan 28, 2019

It's the light version of my try to refactor LdaMulticore horpto@16fa8fa
I'm not sure should I to continue work on that branch. I've tried to extract work with the queues and pool in the separate entity and then use it as a base for others *Multicore.

@menshikh-iv menshikh-iv changed the title Move out process_result_queue from cycle in LdaMulticore Move out process_result_queue from cycle in LdaMulticore Jan 29, 2019
@menshikh-iv
Copy link
Contributor

awesome @horpto ⭐

@menshikh-iv menshikh-iv merged commit 59cf775 into piskvorky:develop Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horpto @menshikh-iv