Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update CHANGELOG for the Gensim 4.1.0 release #3203

Merged
merged 7 commits into from
Aug 7, 2021
Merged

Conversation

piskvorky
Copy link
Owner

@piskvorky piskvorky commented Jul 26, 2021

Fixes #3199.

@mpenkov I also linked from CHANGELOG to the new EnsambleLDA tutorial which isn't "live" yet: https://radimrehurek.com/gensim/auto_examples/tutorials/run_ensemblelda.html

Once we release & rebuild & upload the docs, the link should work. But let's verify.

@piskvorky piskvorky requested a review from mpenkov July 26, 2021 13:37
@mpenkov
Copy link
Collaborator

mpenkov commented Jul 27, 2021

@piskvorky I added additional info about backwards incompatibilities and fixed some typos, please have a look.

Copy link
Owner Author

@piskvorky piskvorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, looks good! Sorry the PR took me so long, I was sick last week.

CHANGELOG.md Outdated Show resolved Hide resolved
@piskvorky piskvorky requested a review from gojomo July 27, 2021 05:59
@piskvorky
Copy link
Owner Author

piskvorky commented Jul 27, 2021

FYI, running the generate_changelog.py script failed with some 403 API error:

Screen Shot 2021-07-26 at 15 01 42

I contacted the Github support, this is their answer:

Thanks for writing in to GitHub Support!

I was able to find in our logs some of the instances of the request made to that endpoint( https://api.github.com/repos/RaRe-Technologies/gensim...).

You're hitting the abuse rate limits and are different from our primary rate limits which are documented here:

https://docs.github.com/free-pro-team@latest/rest/overview/resources-in-the-rest-api#rate-limiting

The abuse rate limits are primarily here to ensure the API's availability by limiting spikes in requests, especially expensive requests. This normally happens when users make lots of requests in a short period of time, especially requests that consume a lot of resources, and also when making requests concurrently.

There's documentation on the abuse rate limits here along with advice on avoiding them and what to do if you do hit them:

https://docs.github.com/free-pro-team@latest/rest/guides/best-practices-for-integrators#dealing-with-abuse-rate-limits

The abuse rate limits are necessary and ensure the stability of the platform for all customers; we're not able to disable or increase them. We recommend checking out that guide to make sure you're able to handle these responses and let us know if you have any other questions about this!

Looks like the solution will be to simply wait 1 sec between the Github API requests.

@piskvorky piskvorky merged commit 266a014 into develop Aug 7, 2021
@piskvorky piskvorky deleted the changelog42 branch August 7, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review change log for 4.1.0
2 participants